Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for aliases in tests #2257

Merged
merged 2 commits into from Apr 28, 2019
Merged

Wait for aliases in tests #2257

merged 2 commits into from Apr 28, 2019

Conversation

AndyBitz
Copy link
Contributor

We'll need to wait a bit after the deployment url returns something to verify that the deployment aliases are assigned again.

@AndyBitz AndyBitz requested a review from leo April 28, 2019 15:09
@codecov-io
Copy link

Codecov Report

Merging #2257 into canary will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2257      +/-   ##
==========================================
+ Coverage   10.43%   10.43%   +<.01%     
==========================================
  Files         246      246              
  Lines        9020     9024       +4     
  Branches      989      990       +1     
==========================================
+ Hits          941      942       +1     
- Misses       7955     7958       +3     
  Partials      124      124
Impacted Files Coverage Δ
src/commands/dev/lib/builder-cache.ts 65.57% <0%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310e1b4...ee1ca38. Read the comment docs.

@leo leo merged commit 2cf846e into canary Apr 28, 2019
@leo leo deleted the fix-alias-tests branch April 28, 2019 15:35
leo pushed a commit that referenced this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants