Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error for .env and .env.build #2261

Merged
merged 4 commits into from Apr 28, 2019
Merged

Fixed error for .env and .env.build #2261

merged 4 commits into from Apr 28, 2019

Conversation

leo
Copy link
Contributor

@leo leo commented Apr 28, 2019

This PR introduces two things:

  • A guide for the error about missing env variables in development
  • The error will not be reported to Sentry anymore

@codecov-io
Copy link

codecov-io commented Apr 28, 2019 •
edited

Codecov Report

Merging #2261 into canary will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2261      +/-   ##
==========================================
+ Coverage   10.44%   10.46%   +0.01%     
==========================================
  Files         246      246              
  Lines        9036     9040       +4     
  Branches      993      994       +1     
==========================================
+ Hits          944      946       +2     
- Misses       7965     7967       +2     
  Partials      127      127
Impacted Files Coverage Δ
src/util/errors-ts.ts 46.24% <ø> (-0.27%) ⬇️
src/commands/dev/dev.ts 0% <ø> (ø) ⬆️
src/commands/dev/lib/dev-server.ts 38.6% <0%> (-0.22%) ⬇️
src/commands/dev/lib/builder-cache.ts 65.57% <0%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112497d...81910e3. Read the comment docs.

mcsdevv
mcsdevv approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@mcsdevv mcsdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

TooTallNate and others added 2 commits April 28, 2019 21:27
@TooTallNate @leo
Update errors/missing-env-file.md
3332c43 
Co-Authored-By: leo <mindrun@icloud.com>
@TooTallNate @leo
Update errors/missing-env-file.md
81910e3 
Co-Authored-By: leo <mindrun@icloud.com>
@leo leo removed the request for review from thasophearak April 28, 2019 19:27
@leo leo merged commit 18f06fd into canary Apr 28, 2019
@leo leo deleted the env-error branch April 28, 2019 19:45
leo added a commit that referenced this pull request Apr 29, 2019
@leo
Fixed error for .env and .env.build (#2261)
18dc7cb 
* Do not report env errors to Sentry

* Added guide for missing env file in dev mode

* Update errors/missing-env-file.md

Co-Authored-By: leo <mindrun@icloud.com>

* Update errors/missing-env-file.md

Co-Authored-By: leo <mindrun@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate left review comments

@mcsdevv mcsdevv mcsdevv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leo @codecov-io @TooTallNate @mcsdevv