[now dev] Install builders with yarn instead of npm
#2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Apr 29, 2019
styfle
approved these changes
Apr 29, 2019
Also invokes via `process.execPath` so that the pkg'd node is used instead of a global one. Depends on #2270.
TooTallNate
force-pushed
the
update/now-dev-use-yarn-to-install-builders
branch
from
30d3726
to
7188502
Compare
Not the `node_modules/.bin` dir, because `yarn` cleans up that directory when installing modules, so it deletes itself.
Co-Authored-By: TooTallNate <n@n8.io>
Codecov Report
@@ Coverage Diff @@
## canary #2272 +/- ##
==========================================
+ Coverage 10.35% 10.59% +0.24%
==========================================
Files 246 246
Lines 9032 9023 -9
Branches 987 986 -1
==========================================
+ Hits 935 956 +21
+ Misses 7986 7953 -33
- Partials 111 114 +3
Continue to review full report at Codecov.
|
leo
pushed a commit
that referenced
this pull request
Apr 30, 2019
* [now dev] Install builders with `yarn` instead of `npm` Also invokes via `process.execPath` so that the pkg'd node is used instead of a global one. Depends on #2270. * Install `yarn` to the builder cache dir Not the `node_modules/.bin` dir, because `yarn` cleans up that directory when installing modules, so it deletes itself. * Remove unnecessary unit test * Always install `yarn` * Pass in the `yarnPath` to `installBuilders()` * Restore unit test * Remove unused `delimiter` import Co-Authored-By: TooTallNate <n@n8.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2270.