Adjust now init and now dev to not require a login token
#2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two commands should not require a login token because they do not interact with the Now API.
TooTallNate
commented
May 7, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2325 +/- ##
==========================================
- Coverage 11.1% 10.67% -0.43%
==========================================
Files 247 247
Lines 9090 9043 -47
Branches 1007 994 -13
==========================================
- Hits 1009 965 -44
+ Misses 7967 7962 -5
- Partials 114 116 +2
Continue to review full report at Codecov.
|
It's not an existing command.
leo
approved these changes
May 7, 2019
leo
pushed a commit
that referenced
this pull request
May 20, 2019
* Adjust `now init` and `now dev` to not require a login token These two commands should not require a login token because they do not interact with the Now API. * Remove `config` from `subcommandsWithoutToken` array It's not an existing command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commands should not require a login token because they do not interact with the Now API.