[now dev] Use the dev server cwd as builder's workPath
#2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #2326 +/- ##
==========================================
+ Coverage 10.63% 11.52% +0.89%
==========================================
Files 247 247
Lines 9052 9047 -5
Branches 994 994
==========================================
+ Hits 963 1043 +80
+ Misses 7979 7894 -85
Partials 110 110
Continue to review full report at Codecov.
|
|
Can we add a basic integration test that runs |
Rather than copying the source files into a temporary directory, simply use the existing source files in the `cwd`. This will make subsequent boots of `now dev` be faster (i.e. because the `node_modules` directory will already be in place), as well as use much less space on the filesystem because temporary directory are no longer being used. This will require some changes to the builders and `@now/build-utils`, to ensure that the `download()` function is always installing into `workPath`, and that the `meta` object passed to the `build()` function is also passed into the `download()` function. For example: - vercel/now-builders#474 - vercel/now-builders#475
This makes `download()` be a no-op when running in `now dev`.
TooTallNate
force-pushed
the
update/now-dev-use-cwd-as-workPath
branch
from
e2bc5cb
to
a66e046
Compare
TooTallNate
changed the title
cwd as builder's workPathcwd as builder's workPath
leo
approved these changes
May 10, 2019
Closed
leo
pushed a commit
that referenced
this pull request
May 20, 2019
* [now dev] Use the dev server `cwd` as builder's `workPath` Rather than copying the source files into a temporary directory, simply use the existing source files in the `cwd`. This will make subsequent boots of `now dev` be faster (i.e. because the `node_modules` directory will already be in place), as well as use much less space on the filesystem because temporary directory are no longer being used. This will require some changes to the builders and `@now/build-utils`, to ensure that the `download()` function is always installing into `workPath`, and that the `meta` object passed to the `build()` function is also passed into the `download()` function. For example: - https://github.com/zeit/now-builders/pull/474 - https://github.com/zeit/now-builders/pull/475 * Update `@now/build-utils` to v0.5.5-canary.1 This makes `download()` be a no-op when running in `now dev`. * Add test case for `@now/next` * Fix debug log formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than copying the source files into a temporary directory, simply use the existing source files in the
cwd. This will make subsequent boots ofnow devbe faster (i.e. because thenode_modulesdirectory will already be in place), as well as use much less space on the filesystem because temporary directory are no longer being used.This will require some changes to the builders and
@now/build-utils, to ensure that thedownload()function is always installing intoworkPath, and that themetaobject passed to thebuild()function is also passed into thedownload()function.For example:
Blockers:
cwddir being watched bynsfw(i.e.node_modules), the watcher will error on some platforms (for example Windows) because there's too many files.nsfwcurrently does not have "ignore" capabilities, see How to ignore certain subdirectories? Axosoft/nsfw#54.