[now dev] Mix in routes query params when proxying to a URL #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #2330 +/- ##
==========================================
- Coverage 10.67% 10.63% -0.04%
==========================================
Files 247 247
Lines 9043 9051 +8
Branches 994 993 -1
==========================================
- Hits 965 963 -2
- Misses 7962 7978 +16
+ Partials 116 110 -6
Continue to review full report at Codecov.
|
|
Meh. Test is failing 😢 |
leo
approved these changes
May 10, 2019
…nts with wrong config"
This was referenced May 14, 2019
leo
pushed a commit
that referenced
this pull request
May 20, 2019
* [now dev] Mix in routes query params when proxying to a URL Fixes #2289. * Refactor unit tests and add a unit test for proxy passing with query params * Fix TypeScript compile error * [DEBUG] Disable proxy pass unit test * Run unit tests serially * Remove `console.error()` in unit test * Temporarily disable integration test "try to create a builds deployments with wrong config"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2289.