[now dev] Strip prefixed / when doing routes matching
#2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
May 23, 2019
styfle
reviewed
May 23, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2361 +/- ##
==========================================
+ Coverage 10.9% 10.94% +0.03%
==========================================
Files 250 250
Lines 9031 9036 +5
Branches 991 993 +2
==========================================
+ Hits 985 989 +4
Misses 7945 7945
- Partials 101 102 +1
Continue to review full report at Codecov.
|
The prefixed `/` is implicit when matching routes, so strip them so that they are optional. This matches the behavior in production.
TooTallNate
force-pushed
the
fix/now-dev-routes-without-slash-src-prefix
branch
from
4cf65e0
to
027bebb
Compare
styfle
approved these changes
May 25, 2019
TooTallNate
added a commit
that referenced
this pull request
Jun 5, 2019
* [now dev] Strip prefixed `/` when doing routes matching The prefixed `/` is implicit when matching routes, so strip them so that they are optional. This matches the behavior in production. * Fix unit tests * More readable * Add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefixed
/is implicit when matching routes, so strip them so that they are optional. This matches the behavior in production.