Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-init] Check for dir existence prior to download #2379

Merged
merged 1 commit into from May 25, 2019
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented May 25, 2019

This is a minor enhancement to the way now init works.

This PR will check if the folder exists prior to fetching the tar.gz from the server so that the command can fail fast.

@styfle styfle requested review from TooTallNate and leo May 25, 2019 17:42
@codecov-io
Copy link

Codecov Report

Merging #2379 into canary will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           canary   #2379   +/-   ##
======================================
  Coverage    10.9%   10.9%           
======================================
  Files         250     250           
  Lines        9031    9031           
  Branches      991     991           
======================================
  Hits          985     985           
  Misses       7945    7945           
  Partials      101     101
Impacted Files Coverage Δ
src/commands/init/init.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca17c6d...aa99e42. Read the comment docs.

@styfle styfle merged commit 7bd40f0 into canary May 25, 2019
@styfle styfle deleted the fix-init-fetch branch May 25, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants