[now dev] Move the MissingDotenvVarsError handling to the correct place
#2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lace `validateEnvConfig()` used to be invoked inside of `validateNowConfig()`, but now it is invoked separately. Explicitly exiting the process avoids reports going to Sentry.
Codecov Report
@@ Coverage Diff @@
## canary #2489 +/- ##
==========================================
- Coverage 11.45% 11.38% -0.08%
==========================================
Files 256 256
Lines 9250 9247 -3
Branches 1033 1031 -2
==========================================
- Hits 1060 1053 -7
- Misses 8079 8082 +3
- Partials 111 112 +1
Continue to review full report at Codecov.
|
leo
approved these changes
Jul 2, 2019
leo
pushed a commit
that referenced
this pull request
Jul 7, 2019
…lace (#2489) `validateEnvConfig()` used to be invoked inside of `validateNowConfig()`, but now it is invoked separately. Explicitly exiting the process avoids reports going to Sentry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateEnvConfig()used to be invoked inside ofvalidateNowConfig(), but now it is invoked separately.Explicitly exiting the process avoids reports going to Sentry.