Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Add support for deployments without now.json #2498

Merged
merged 17 commits into from
Jul 8, 2019

Conversation

AndyBitz
Copy link
Contributor

@AndyBitz AndyBitz commented Jul 5, 2019

Add zero config for now dev

Requires this to be on stable: https://github.com/zeit/now-builders/pull/705

@TooTallNate TooTallNate changed the title [now-dev] Add zero config [now dev] Add zero config Jul 6, 2019
@codecov-io
Copy link

codecov-io commented Jul 7, 2019

Codecov Report

Merging #2498 into canary will increase coverage by 0.29%.
The diff coverage is 48.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2498      +/-   ##
==========================================
+ Coverage   11.56%   11.86%   +0.29%     
==========================================
  Files         257      257              
  Lines        9258     9306      +48     
  Branches     1031     1045      +14     
==========================================
+ Hits         1071     1104      +33     
- Misses       8074     8083       +9     
- Partials      113      119       +6
Impacted Files Coverage Δ
src/util/dev/builder.ts 67.85% <ø> (+0.19%) ⬆️
src/util/get-files.ts 90.18% <ø> (+0.31%) ⬆️
src/util/dev/server.ts 51.11% <48.93%> (+1.44%) ⬆️
src/util/metrics.ts 61.53% <0%> (-6.65%) ⬇️
src/util/dev/builder-cache.ts 63.33% <0%> (-1.33%) ⬇️
src/util/output/create-output.ts 40.54% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900c2a1...7ef0c29. Read the comment docs.

@leo leo changed the title [now dev] Add zero config [now dev] Add support for deployments without now.json Jul 8, 2019
@AndyBitz AndyBitz requested a review from TooTallNate July 8, 2019 19:13
@AndyBitz AndyBitz requested a review from TooTallNate July 8, 2019 19:18
src/util/dev/server.ts Outdated Show resolved Hide resolved
src/util/dev/server.ts Outdated Show resolved Hide resolved
Copy link
Member

@TooTallNate TooTallNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some unit tests to the test/dev-server.unit.js file with some fixtures utilizing this new system?

@AndyBitz AndyBitz requested a review from TooTallNate July 8, 2019 20:44
@AndyBitz AndyBitz merged commit 8513ff2 into canary Jul 8, 2019
@AndyBitz AndyBitz deleted the add/zero-config-for-now-dev branch July 8, 2019 21:05
AndyBitz added a commit that referenced this pull request Jul 12, 2019
* [now-dev] Add zero config

* Update @now/build-utils

* Update @now/build-utils

* Escape glob

* Fix windows and group globbing

* Made sure routes and builds get updated on file events

* Removed useless check

* Add unit tests

* Use fetch instead of get
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants