Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Set Now response headers when proxy passing in routes #2500

Merged
merged 4 commits into from
Jul 8, 2019

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Jul 6, 2019

This matches the behavior in production.

@TooTallNate TooTallNate requested a review from leo as a code owner July 6, 2019 01:22
@codecov-io
Copy link

Codecov Report

Merging #2500 into canary will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #2500      +/-   ##
=========================================
+ Coverage   11.37%   11.4%   +0.02%     
=========================================
  Files         256     256              
  Lines        9247    9252       +5     
  Branches     1031    1032       +1     
=========================================
+ Hits         1052    1055       +3     
- Misses       8083    8085       +2     
  Partials      112     112
Impacted Files Coverage Δ
src/util/dev/server.ts 47.59% <ø> (+0.33%) ⬆️
src/util/dev/builder-cache.ts 67.24% <0%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2414767...c4e7fda. Read the comment docs.

@leo leo merged commit 900c2a1 into canary Jul 8, 2019
@leo leo deleted the update/now-dev-proxy-pass-headers branch July 8, 2019 20:02
AndyBitz pushed a commit that referenced this pull request Jul 12, 2019
)

* [now dev] Set Now response headers when proxy passing in `routes`

* Fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants