[now dev] Add etag response header for Lambda invocations
#2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behavior in production.
Codecov Report
@@ Coverage Diff @@
## canary #2502 +/- ##
==========================================
+ Coverage 11.37% 11.43% +0.06%
==========================================
Files 256 257 +1
Lines 9247 9250 +3
Branches 1031 1030 -1
==========================================
+ Hits 1052 1058 +6
+ Misses 8083 8080 -3
Partials 112 112
Continue to review full report at Codecov.
|
leo
approved these changes
Jul 7, 2019
leo
pushed a commit
that referenced
this pull request
Jul 7, 2019
This matches the behavior in production.
TooTallNate
added a commit
that referenced
this pull request
Jul 9, 2019
…2520) * [now dev] Revert "Add `etag` response header for Lambda invocations" This reverts commit f80f1f7 (#2502). `ETag` header is only sent in production when the lambda function sets the "stale-while-revalidate" cache-control header, which will be implemented in a separate PR. * Remove `etag` test assertion
AndyBitz
pushed a commit
that referenced
this pull request
Jul 12, 2019
…2520) * [now dev] Revert "Add `etag` response header for Lambda invocations" This reverts commit f80f1f7 (#2502). `ETag` header is only sent in production when the lambda function sets the "stale-while-revalidate" cache-control header, which will be implemented in a separate PR. * Remove `etag` test assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the behavior in production.