Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Add test case for lazily installing builders #2510

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

TooTallNate
Copy link
Member

This is a follow up for #2509 to add a unit/regression test ensuring correct functionality.

This is a follow up for #2509 to add a unit/regression test ensuring
correct functionality.
@TooTallNate TooTallNate requested a review from leo as a code owner July 9, 2019 00:32
@codecov-io
Copy link

Codecov Report

Merging #2510 into canary will decrease coverage by 0.41%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2510      +/-   ##
==========================================
- Coverage   12.35%   11.94%   -0.42%     
==========================================
  Files         257      257              
  Lines        9359     9304      -55     
  Branches     1062     1046      -16     
==========================================
- Hits         1156     1111      -45     
+ Misses       8084     8072      -12     
- Partials      119      121       +2
Impacted Files Coverage Δ
src/util/dev/builder-cache.ts 68.85% <71.42%> (-2.33%) ⬇️
src/util/metrics.ts 68.18% <0%> (-11.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed9ba4...1923fc7. Read the comment docs.

@TooTallNate TooTallNate merged commit 9919701 into canary Jul 9, 2019
@TooTallNate TooTallNate deleted the add/now-dev-lazy-builder-install-test branch July 9, 2019 00:44
AndyBitz pushed a commit that referenced this pull request Jul 12, 2019
This is a follow up for #2509 to add a unit/regression test ensuring
correct functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants