Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Update @now/build-utils and handle warnings #2523

Merged
merged 9 commits into from
Jul 10, 2019

Conversation

AndyBitz
Copy link
Contributor

Update @now/build-utils and handle warnings

src/util/dev/server.ts Outdated Show resolved Hide resolved
@AndyBitz AndyBitz marked this pull request as ready for review July 10, 2019 15:59
@AndyBitz AndyBitz requested review from leo and styfle as code owners July 10, 2019 15:59
@codecov-io
Copy link

Codecov Report

Merging #2523 into canary will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2523      +/-   ##
==========================================
- Coverage   12.64%   12.64%   -0.01%     
==========================================
  Files         256      256              
  Lines        9315     9327      +12     
  Branches     1054     1056       +2     
==========================================
+ Hits         1178     1179       +1     
- Misses       8015     8025      +10     
- Partials      122      123       +1
Impacted Files Coverage Δ
src/util/index.js 0% <0%> (ø) ⬆️
src/util/dev/server.ts 60.43% <40%> (-0.32%) ⬇️
src/util/metrics.ts 61.53% <0%> (-6.65%) ⬇️
src/util/dev/builder-cache.ts 70.4% <0%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18196b...03a4426. Read the comment docs.

@AndyBitz AndyBitz merged commit 954d433 into canary Jul 10, 2019
@AndyBitz AndyBitz deleted the now-dev/bump-build-utils branch July 10, 2019 16:14
AndyBitz added a commit that referenced this pull request Jul 12, 2019
* [now dev] Update @now/build-utils and handle warnings

* Display warnings from response headers for deployment creation

* Update src/util/dev/server.ts

Co-Authored-By: Nathan Rajlich <n@n8.io>

* Apply routes only when there are no builds

* Updated the build utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants