[now dev] Render directory listing for Now v2 projects #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before directory listings only worked for "all static" deployments since `now dev` would shell out to `serve-handler` to do the rendering. Now the directory listing rendering logic is moved into `now dev` which allows projects with Lambdas to also serve the directory listing (previously they would just 404). This removes the special-casing of "all static" deployments so that there's only one code path. Fixes #2161. Fixes #2417.
Codecov Report
@@ Coverage Diff @@
## canary #2528 +/- ##
=========================================
- Coverage 13.21% 13.01% -0.2%
=========================================
Files 256 256
Lines 9384 9357 -27
Branches 1076 1061 -15
=========================================
- Hits 1240 1218 -22
+ Misses 8022 8019 -3
+ Partials 122 120 -2
Continue to review full report at Codecov.
|
AndyBitz
pushed a commit
that referenced
this pull request
Jul 12, 2019
* [now dev] Render directory listing for Now v2 projects Before directory listings only worked for "all static" deployments since `now dev` would shell out to `serve-handler` to do the rendering. Now the directory listing rendering logic is moved into `now dev` which allows projects with Lambdas to also serve the directory listing (previously they would just 404). This removes the special-casing of "all static" deployments so that there's only one code path. Fixes #2161. Fixes #2417. * Move `serve-handler/src/directory` types to root * Set `Content-Length` header for dir listing * Add unit tests for directory listing * Fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before directory listings only worked for "all static" deployments since
now devwould shell out toserve-handlerto do the rendering.Now the directory listing rendering logic is moved into
now devwhich allows projects with Lambdas to also serve the directory listing (previously they would just 404).This removes the special-casing of "all static" deployments so that there's only one code path.
Fixes #2161.
Fixes #2417.