Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration and basic integration tests for now dev #2553

Merged
merged 19 commits into from
Jul 21, 2019
Merged

Add configuration and basic integration tests for now dev #2553

merged 19 commits into from
Jul 21, 2019

Conversation

thasophearak
Copy link
Contributor

@thasophearak thasophearak commented Jul 16, 2019 •
edited

This PR add integration tests for now dev, it covers:

  • 00-list-directory
  • 01-node
  • 02-angular-node
  • 07-hexo-node
  • 10-nextjs-node
  • 12-polymer-node
  • 13-preact-node
  • 14-svelte-node
  • 16-vue-node
  • 17-vuepress-node

@leo leo marked this pull request as ready for review July 16, 2019 12:27
@leo leo requested review from leo and TooTallNate as code owners July 16, 2019 12:27
@thasophearak
Copy link
Contributor Author

The build failed because of ncc trying to resolve test/dev/fixtures/02-angular-node/e2e/src/app.e2e-spec.ts

In https://github.com/zeit/now-cli/blob/canary/build.js#L64, we only set src as input, is there a way that we tell ncc to ignore test?

cc @styfle

@styfle
Copy link
Member

styfle commented Jul 16, 2019

It should already ignore test because /src/index.js doesn't ever require() anything in test (as far as I know).

Perhaps you just need to add "include": ["src/**/*"] in tsconfig.json like so: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html

@codecov-io
Copy link

codecov-io commented Jul 17, 2019 •
edited

Codecov Report

Merging #2553 into canary will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           canary    #2553   +/-   ##
=======================================
  Coverage   13.83%   13.83%           
=======================================
  Files         257      257           
  Lines        9360     9360           
  Branches     1058     1058           
=======================================
  Hits         1295     1295           
  Misses       7943     7943           
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0245a04...fc0df3f. Read the comment docs.

@leo leo removed the request for review from TooTallNate July 21, 2019 23:25
@leo leo merged commit 7674a4a into canary Jul 21, 2019
@leo leo deleted the add/now-dev-integration-test branch July 21, 2019 23:48
AndyBitz pushed a commit that referenced this pull request Jul 25, 2019
@thasophearak @AndyBitz
Add configuration and basic integration tests for now dev (#2553)
e45e403 
* Add configuration and basic integration tests for `now dev`

* Add test fixtures from `now-examples`

* Add `include` to `tsconfig.json`

* Increase retries for 00-list-directory

* Increase retries for `03-aurelia-node`

* Enable test fixtures for hexo, hugo, next, polymer, preact, svelte, vue, and vuepress

* Increase retries for `08-hugo-node`

* Disable `08-hugo-node` fixture

* Enable `04-create-react-app-node` test

* Disable `04-create-react-app-node` test

* Better name for now dev test job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo leo leo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thasophearak @styfle @codecov-io @leo @TooTallNate