[now dev] Wait for blocking builds to complete before handling requests #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #2562 +/- ##
=========================================
+ Coverage 7.95% 7.95% +<.01%
=========================================
Files 258 258
Lines 9383 9401 +18
Branches 1063 1068 +5
=========================================
+ Hits 746 748 +2
- Misses 8588 8604 +16
Partials 49 49
Continue to review full report at Codecov.
|
AndyBitz
approved these changes
Jul 17, 2019
styfle
reviewed
Jul 17, 2019
After the `now dev` server has already booted, if you delete a build match that previously required a build at bootup time (i.e. `@now/next`) from the `builds` array in `now.json` (i.e. change the builder to `@now/static`), and then change it back to `@now/next`, then previously the build would never execute. With this change, the blocking build occurs as expected, and any HTTP requests that occur are blocked until that build has completed.
TooTallNate
force-pushed
the
update/now-dev-blocking-builds
branch
from
6e80797
to
7d1b727
Compare
styfle
approved these changes
Jul 23, 2019
TooTallNate
added a commit
that referenced
this pull request
Jul 24, 2019
PR #2562 caused an issue with blocking builds at bootup being built twice, which is problematic when i.e. running `yarn` simultaneously on the same directory causing cache corruption issues.
TooTallNate
added a commit
that referenced
this pull request
Jul 24, 2019
PR #2562 caused an issue with blocking builds at bootup being built twice, which is problematic when i.e. running `yarn` simultaneously on the same directory causing cache corruption issues.
AndyBitz
pushed a commit
that referenced
this pull request
Jul 25, 2019
…ts (#2562) * [now dev] Wait for blocking builds to complete before handling requests After the `now dev` server has already booted, if you delete a build match that previously required a build at bootup time (i.e. `@now/next`) from the `builds` array in `now.json` (i.e. change the builder to `@now/static`), and then change it back to `@now/next`, then previously the build would never execute. With this change, the blocking build occurs as expected, and any HTTP requests that occur are blocked until that build has completed. * Prettier * Better diff * Add test
AndyBitz
pushed a commit
that referenced
this pull request
Jul 25, 2019
PR #2562 caused an issue with blocking builds at bootup being built twice, which is problematic when i.e. running `yarn` simultaneously on the same directory causing cache corruption issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the
now devserver has already booted, if you delete a build match that previously required a build at bootup time (i.e.@now/next) from thebuildsarray innow.json(i.e. change the builder to@now/static), and then change it back to@now/next, then previously the build would never execute.With this change, the blocking build occurs as expected, and any HTTP requests that occur are blocked until that build has completed.