Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error for missing build script instead of warning #2588

Merged
merged 2 commits into from
Jul 21, 2019

Conversation

AndyBitz
Copy link
Contributor

Bump @now/build-utils and throw errors

@codecov-io
Copy link

codecov-io commented Jul 21, 2019

Codecov Report

Merging #2588 into canary will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2588      +/-   ##
==========================================
- Coverage   13.82%   13.81%   -0.01%     
==========================================
  Files         257      257              
  Lines        9348     9347       -1     
  Branches     1059     1058       -1     
==========================================
- Hits         1292     1291       -1     
  Misses       7934     7934              
  Partials      122      122
Impacted Files Coverage Δ
src/util/dev/server.ts 64.49% <50%> (-0.35%) ⬇️
src/util/metrics.ts 68.18% <0%> (+6.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9383b2...a68a59e. Read the comment docs.

@AndyBitz AndyBitz merged commit 340537b into canary Jul 21, 2019
@AndyBitz AndyBitz deleted the now-dev/bump-build-utils branch July 21, 2019 19:37
@leo leo changed the title [now dev] Bump @now/build-utils and throw errors Throw error for missing build script instead of warning Jul 24, 2019
AndyBitz added a commit that referenced this pull request Jul 25, 2019
* [now dev] Bump `@now/build-utils` and throw errors

* Fix error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants