Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Print Serving all files as static only once #2590

Merged
merged 6 commits into from
Jul 22, 2019

Conversation

AndyBitz
Copy link
Contributor

Print Serving all files as static only once, as it will get printed every time a file changes otherwise.

@codecov-io
Copy link

codecov-io commented Jul 21, 2019

Codecov Report

Merging #2590 into canary will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2590      +/-   ##
==========================================
+ Coverage   13.83%   13.83%   +<.01%     
==========================================
  Files         257      257              
  Lines        9356     9365       +9     
  Branches     1057     1060       +3     
==========================================
+ Hits         1294     1296       +2     
- Misses       7940     7947       +7     
  Partials      122      122
Impacted Files Coverage Δ
src/util/dev/server.ts 64.38% <87.5%> (-0.12%) ⬇️
src/util/metrics.ts 61.53% <0%> (-6.65%) ⬇️
src/util/dev/builder-cache.ts 77.27% <0%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7674a4a...a1afbc4. Read the comment docs.

@AndyBitz AndyBitz merged commit c61502e into canary Jul 22, 2019
@AndyBitz AndyBitz deleted the now-dev/print-info-only-once branch July 22, 2019 00:47
AndyBitz added a commit that referenced this pull request Jul 25, 2019
* [now dev] Print `Serving all files as static` only once

* Track the config state

* Revert "Track the config state"

This reverts commit 9766941.

* Revert "[now dev] Print `Serving all files as static` only once"

This reverts commit 3e30c24.

* Add `isInitialLoad` param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants