[now dev] Fix directory listing race condition #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #2591 +/- ##
==========================================
+ Coverage 13.82% 13.84% +0.01%
==========================================
Files 257 257
Lines 9357 9359 +2
Branches 1058 1058
==========================================
+ Hits 1294 1296 +2
Misses 7941 7941
Partials 122 122
Continue to review full report at Codecov.
|
This reverts commit 6159d65.
styfle
reviewed
Jul 22, 2019
styfle
approved these changes
Jul 22, 2019
AndyBitz
added a commit
that referenced
this pull request
Jul 25, 2019
* [now dev] Fix directory listing race condition * Resolve file names * Check only matched files * Log stdout and stderr * Log expected * Change test * Revert "Change test" This reverts commit 149723b. * Add timeout to request * Adjust retries * Don't use unref * Remove tests * Revert "Remove tests" This reverts commit 6159d65. * Adjusted test * Make sure directory exists * Fix tests * Add yarn.lock * Adjust timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix directory listing race condition