[now dev] Add warning when there are no build matches #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the error in production, except it's just a non-fatal warning when running in `now dev`. This is so that the user can fix the warning without having to restart the `now dev` server.
styfle
approved these changes
Jul 22, 2019
AndyBitz
reviewed
Jul 22, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2594 +/- ##
========================================
- Coverage 8.17% 7.97% -0.2%
========================================
Files 257 257
Lines 9436 9376 -60
Branches 1089 1062 -27
========================================
- Hits 771 748 -23
+ Misses 8612 8579 -33
+ Partials 53 49 -4
Continue to review full report at Codecov.
|
AndyBitz
pushed a commit
that referenced
this pull request
Jul 25, 2019
* [now dev] Add warning when there are no build matches This matches the error in production, except it's just a non-fatal warning when running in `now dev`. This is so that the user can fix the warning without having to restart the `now dev` server. * Add integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the error in production, except it's just a non-fatal warning when running in
now dev. This is so that the user can fix the warning without having to restart thenow devserver.