Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use fs.promises to prevent warnings #2602

Merged
merged 2 commits into from Jul 24, 2019
Merged

Conversation

AndyBitz
Copy link
Contributor

Don't use fs.promises to prevent warnings from node.

@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #2602 into canary will decrease coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #2602      +/-   ##
=========================================
- Coverage    7.95%   7.94%   -0.01%     
=========================================
  Files         258     258              
  Lines        9401    9397       -4     
  Branches     1068    1067       -1     
=========================================
- Hits          748     747       -1     
+ Misses       8604    8601       -3     
  Partials       49      49
Impacted Files Coverage Δ
src/util/read-json-file.ts 0% <ø> (ø) ⬆️
src/commands/deploy/legacy.js 0% <ø> (ø) ⬆️
src/commands/deploy/index.js 0% <ø> (ø) ⬆️
src/util/git.js 0% <ø> (ø) ⬆️
src/util/index.js 0% <0%> (ø) ⬆️
src/util/dev/server.ts 11.28% <0%> (ø) ⬆️
src/util/hash.js 100% <100%> (ø) ⬆️
src/util/read-metadata.js 100% <100%> (ø) ⬆️
src/util/get-files.ts 86.5% <75%> (ø) ⬆️
src/util/metrics.ts 68.18% <0%> (+6.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4e20c...de184d2. Read the comment docs.

@TooTallNate TooTallNate merged commit 862728f into canary Jul 24, 2019
@TooTallNate TooTallNate deleted the remove-promises-fs-api branch July 24, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants