[now dev] Remove useless debug() call
#2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getNowConfig(false)` used to be within this `if` branch, so the debug call made sense there at the time, but as of zero config it got moved to always be invoked, so this `debug()` call doesn't make sense anymore.
AndyBitz
approved these changes
Jul 24, 2019
styfle
approved these changes
Jul 24, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2619 +/- ##
========================================
- Coverage 8.25% 7.95% -0.3%
========================================
Files 258 258
Lines 9477 9399 -78
Branches 1100 1067 -33
========================================
- Hits 782 748 -34
+ Misses 8644 8602 -42
+ Partials 51 49 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getNowConfig(false)used to be within thisifbranch, so the debug call made sense there at the time, but as of zero config it got moved to always be invoked, so thisdebug()call doesn't make sense anymore.