[now deploy] Respect --debug flag for API Client
#2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging #2606, I noticed that the `Client` instances for `now deploy` were not being supplied the appropriate `debug` flag based on the command line args.
AndyBitz
approved these changes
Jul 24, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2625 +/- ##
=========================================
- Coverage 8.17% 7.96% -0.22%
=========================================
Files 258 258
Lines 9468 9407 -61
Branches 1095 1068 -27
=========================================
- Hits 774 749 -25
+ Misses 8642 8609 -33
+ Partials 52 49 -3
Continue to review full report at Codecov.
|
AndyBitz
pushed a commit
that referenced
this pull request
Jul 25, 2019
While debugging #2606, I noticed that the `Client` instances for `now deploy` were not being supplied the appropriate `debug` flag based on the command line args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #2606, I noticed that the
Clientinstances fornow deploywere not being supplied the appropriatedebugflag based on the command line args.