Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Fix aurelia test #2660

Merged
merged 4 commits into from Jul 30, 2019
Merged

[now dev] Fix aurelia test #2660

merged 4 commits into from Jul 30, 2019

Conversation

AndyBitz
Copy link
Contributor

Fix aurelia test, a dependency has changed an now the tests won't work anymore, I've made sure they are locked.

@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

Merging #2660 into canary will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #2660      +/-   ##
=========================================
- Coverage    7.92%   7.84%   -0.08%     
=========================================
  Files         259     259              
  Lines       10444   10408      -36     
  Branches     1321    1319       -2     
=========================================
- Hits          828     817      -11     
+ Misses       9563    9538      -25     
  Partials       53      53
Impacted Files Coverage Δ
src/util/dev/yarn-installer.ts 37.28% <0%> (-0.81%) ⬇️
src/util/dev/builder-cache.ts 32.79% <0%> (-0.71%) ⬇️
src/util/dev/server.ts 11.52% <0%> (-0.25%) ⬇️
src/util/dev/builder.ts 12.43% <0%> (+0.26%) ⬆️
src/util/get-files.ts 87.07% <0%> (+0.81%) ⬆️
src/util/output/create-output.ts 29.54% <0%> (+2.46%) ⬆️
src/util/metrics.ts 68.18% <0%> (+6.64%) ⬆️
src/util/prefer-v2-deployment.ts 70.96% <0%> (+8.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257f5f2...d6ff15e. Read the comment docs.

@AndyBitz AndyBitz merged commit f016f05 into canary Jul 30, 2019
@AndyBitz AndyBitz deleted the fix/now-dev-test branch July 30, 2019 00:22
AndyBitz added a commit that referenced this pull request Aug 5, 2019
* [now dev] Fix aurelia test

* Enable aurelia test again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants