New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[now dev] Bundle canary
builders for Now CLI canary
#2661
Conversation
Codecov Report
@@ Coverage Diff @@
## canary #2661 +/- ##
=========================================
+ Coverage 7.85% 8.07% +0.22%
=========================================
Files 259 259
Lines 10404 10453 +49
Branches 1319 1323 +4
=========================================
+ Hits 817 844 +27
- Misses 9534 9552 +18
- Partials 53 57 +4
Continue to review full report at Codecov.
|
canary
builders for Now CLI canarycanary
builders for Now CLI canary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but I'm wondering if it would make sense to include both versions for Now CLI canary, since I don't think that just because someone uses Now CLI canary they'd like to use canary builders as well
@AndyBitz I'd rather not, as there's not really a "clean" way to accomplish that without including two tarballs (one for stable and one for canary) and would make the logic more complicated. Users can still use stable builders, the |
This reverts commit 9ea9675.
* [now dev] Bundle `canary` builders for Now CLI canary Closes #2641. * Add unit tests * More unit tests * Use `semver.parse()` in `getDistTag()` * Convert build script to TypeScript, DRY the `getDistTag()` function * Prettier
Closes #2641.
I'm still adding unit tests for the "filter" function since the logic is not very straightforward and there's many edge cases.