Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Bundle canary builders for Now CLI canary #2661

Merged
merged 15 commits into from Jul 30, 2019

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Jul 29, 2019

Closes #2641.

I'm still adding unit tests for the "filter" function since the logic is not very straightforward and there's many edge cases.

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #2661 into canary will increase coverage by 0.22%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #2661      +/-   ##
=========================================
+ Coverage    7.85%   8.07%   +0.22%     
=========================================
  Files         259     259              
  Lines       10404   10453      +49     
  Branches     1319    1323       +4     
=========================================
+ Hits          817     844      +27     
- Misses       9534    9552      +18     
- Partials       53      57       +4
Impacted Files Coverage Δ
src/util/dev/server.ts 11.76% <0%> (+0.24%) ⬆️
src/util/dev/builder-cache.ts 39.9% <64%> (+7.1%) ⬆️
src/util/prefer-v2-deployment.ts 62.85% <0%> (-8.12%) ⬇️
src/util/metrics.ts 61.53% <0%> (-6.65%) ⬇️
src/util/dev/router.ts 75.71% <0%> (-4.59%) ⬇️
src/util/output/create-output.ts 27.08% <0%> (-2.47%) ⬇️
src/util/get-files.ts 86.26% <0%> (-0.82%) ⬇️
src/util/dev/builder.ts 12.16% <0%> (-0.27%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49293ae...288465e. Read the comment docs.

@TooTallNate TooTallNate changed the title [now dev] WIP Bundle canary builders for Now CLI canary [now dev] Bundle canary builders for Now CLI canary Jul 30, 2019
Copy link
Contributor

@AndyBitz AndyBitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I'm wondering if it would make sense to include both versions for Now CLI canary, since I don't think that just because someone uses Now CLI canary they'd like to use canary builders as well

scripts/build.js Outdated Show resolved Hide resolved
@TooTallNate
Copy link
Member Author

@AndyBitz I'd rather not, as there's not really a "clean" way to accomplish that without including two tarballs (one for stable and one for canary) and would make the logic more complicated.

Users can still use stable builders, the installPackages() function blocks to ensure correctness before booting up the now dev server.

@TooTallNate TooTallNate requested a review from styfle July 30, 2019 19:22
scripts/build.js Outdated Show resolved Hide resolved
@TooTallNate TooTallNate merged commit d29b1b9 into canary Jul 30, 2019
@TooTallNate TooTallNate deleted the update/now-dev-bundle-canary branch July 30, 2019 21:56
AndyBitz pushed a commit that referenced this pull request Aug 5, 2019
* [now dev] Bundle `canary` builders for Now CLI canary

Closes #2641.

* Add unit tests

* More unit tests

* Use `semver.parse()` in `getDistTag()`

* Convert build script to TypeScript, DRY the `getDistTag()` function

* Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship canary Builders with canary Now CLI
4 participants