[now dev] Support JSON and HTML error responses #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #2677 +/- ##
=========================================
+ Coverage 8.14% 8.24% +0.09%
=========================================
Files 259 260 +1
Lines 10470 10516 +46
Branches 1328 1339 +11
=========================================
+ Hits 853 867 +14
- Misses 9559 9591 +32
Partials 58 58
Continue to review full report at Codecov.
|
TooTallNate
changed the title
AndyBitz
reviewed
Aug 1, 2019
styfle
reviewed
Aug 1, 2019
styfle
reviewed
Aug 1, 2019
styfle
reviewed
Aug 1, 2019
styfle
approved these changes
Aug 1, 2019
AndyBitz
approved these changes
Aug 1, 2019
AndyBitz
pushed a commit
that referenced
this pull request
Aug 5, 2019
* [now dev] Support JSON and HTML error responses Closes #2609. * Compile templates for unit tests in CircleCI * Update `ts-node` to v8.3.0 * Convert doT.js compiled templates to TypeScript * Compile templates for lint tests in CircleCI * Print convert time * Add 502 error template * Remove `message` param from `sendError()` * Prettier * Add 404 tests * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same templates as the production proxy uses, but converted to doT.js format.
Closes #2609.