Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[now dev] Allow custom 404 pages via routes #2689

Merged
merged 2 commits into from Aug 2, 2019
Merged

[now dev] Allow custom 404 pages via routes #2689

merged 2 commits into from Aug 2, 2019

Conversation

TooTallNate
Copy link
Member

This matches the behavior in production, which allows a dest to be
provided when defining a status: 404 in the routes configuration.

Related to #2638.

@TooTallNate
[now dev] Allow custom 404 pages via routes
fdd1136 
This matches the behavior in production, which allows a `dest` to be
provided when defining a `status: 404` in the routes configuration.

Related to #2638.
styfle
styfle approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the next PR to touch routes should incorporate @now/routing-utils instead of manually handling this.

@TooTallNate
Copy link
Member Author

This one doesn't really touch routes, but rather the handling of the result of the routing logic.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (canary@eeed5a8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             canary   #2689   +/-   ##
========================================
  Coverage          ?   8.24%           
========================================
  Files             ?     260           
  Lines             ?   10514           
  Branches          ?    1339           
========================================
  Hits              ?     867           
  Misses            ?    9589           
  Partials          ?      58
Impacted Files Coverage Δ
src/util/dev/server.ts 12.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeed5a8...612e199. Read the comment docs.

@TooTallNate TooTallNate merged commit 8e0c1da into canary Aug 2, 2019
@TooTallNate TooTallNate deleted the fix/now-dev-custom-404-routes branch August 2, 2019 18:26
@TooTallNate TooTallNate mentioned this pull request Aug 2, 2019
Merged
AndyBitz pushed a commit that referenced this pull request Aug 5, 2019
@TooTallNate @AndyBitz
[now dev] Allow custom 404 pages via routes (#2689)
188150d 
* [now dev] Allow custom 404 pages via `routes`

This matches the behavior in production, which allows a `dest` to be
provided when defining a `status: 404` in the routes configuration.

Related to #2638.

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@AndyBitz AndyBitz Awaiting requested review from AndyBitz

@leo leo Awaiting requested review from leo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TooTallNate @codecov-io @styfle