Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status code for upload errors #2733

Merged
merged 1 commit into from Aug 9, 2019
Merged

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Aug 9, 2019

This allow us to identify the root cause for the upload problem.

@codecov-io
Copy link

Codecov Report

Merging #2733 into canary will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2733      +/-   ##
==========================================
+ Coverage   13.57%   13.61%   +0.04%     
==========================================
  Files         261      261              
  Lines       10536    10568      +32     
  Branches     1356     1357       +1     
==========================================
+ Hits         1430     1439       +9     
- Misses       8961     8984      +23     
  Partials      145      145
Impacted Files Coverage Δ
src/util/index.js 0% <0%> (ø) ⬆️
src/util/dev/router.ts 78.57% <0%> (-4.77%) ⬇️
src/util/dev/yarn-installer.ts 80.95% <0%> (-3.8%) ⬇️
src/util/output/create-output.ts 37.5% <0%> (-3.41%) ⬇️
src/util/dev/builder-cache.ts 69.84% <0%> (-1.36%) ⬇️
src/util/dev/builder.ts 72.1% <0%> (-1.02%) ⬇️
src/util/get-files.ts 90.1% <0%> (-0.91%) ⬇️
src/util/dev/server.ts 61.22% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48bb49...b1a3369. Read the comment docs.

@AndyBitz AndyBitz merged commit 413fdd7 into canary Aug 9, 2019
@AndyBitz AndyBitz deleted the add-status-code-to-upload-errors branch August 9, 2019 14:07
@arunoda
Copy link
Contributor Author

arunoda commented Aug 9, 2019

Thanks @AndyBitz

AndyBitz pushed a commit that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants