Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now deploy] Fix builds output for failed deployments #2799

Merged
merged 3 commits into from Aug 20, 2019

Conversation

AndyBitz
Copy link
Contributor

Fix builds output for failed deployments

Fixes #2798

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (canary@6211197). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             canary    #2799   +/-   ##
=========================================
  Coverage          ?   13.87%           
=========================================
  Files             ?      262           
  Lines             ?    10599           
  Branches          ?     1365           
=========================================
  Hits              ?     1471           
  Misses            ?     8979           
  Partials          ?      149
Impacted Files Coverage Δ
src/commands/deploy/latest.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6211197...9e375ed. Read the comment docs.

@AndyBitz AndyBitz merged commit 918d605 into canary Aug 20, 2019
@AndyBitz AndyBitz deleted the now-deploy/fix-builds-output branch August 20, 2019 16:13
AndyBitz added a commit that referenced this pull request Aug 20, 2019
* [now deploy] Fix builds output for failed deployments

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong codepath is used for failing build
3 participants