[now-static-build] Fix dev server port detection #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callain
requested review from
AndyBitz,
leo,
styfle and
TooTallNate
as code owners
leo
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
If @AndyBitz and @TooTallNate have no objections, this looks really good!
Codecov Report
@@ Coverage Diff @@
## canary #2879 +/- ##
=======================================
Coverage 13.38% 13.38%
=======================================
Files 268 268
Lines 10342 10342
Branches 1218 1218
=======================================
Hits 1384 1384
Misses 8896 8896
Partials 62 62Continue to review full report at Codecov.
|
TooTallNate
reviewed
Aug 27, 2019
TooTallNate
reviewed
Aug 27, 2019
TooTallNate
reviewed
Aug 27, 2019
styfle
reviewed
Aug 27, 2019
TooTallNate
reviewed
Aug 27, 2019
callain
commented
Aug 27, 2019
TooTallNate
reviewed
Aug 28, 2019
styfle
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Looks good to me, thanks!!
What do you think @TooTallNate ?
styfle
changed the title
|
Up :) |
TooTallNate
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Tested and it works nicely. There's a few "tweaks" I'd still like to make, but I will do that in a separate PR. Thanks @callain!
|
Thanks ! I'm sure it will help a lot of users 😃 |
styfle
pushed a commit
that referenced
this pull request
Sep 17, 2019
* [now-static-build] Fix dev server detection * Code review * Remove unused dependency * Fix the checking by really waiting until the port is reachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really check if the port is reachable instead of reading the console data.
For example CRA does not show the devPort in the console if there is a warning in the code, meaning
now devfail to start.Fixes #2856