Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-cli] Add test for zero-config and canary builders #3009

Merged
merged 8 commits into from Sep 13, 2019

Conversation

AndyBitz
Copy link
Contributor

Add test for zero-config and canary builders.

@AndyBitz AndyBitz marked this pull request as ready for review September 12, 2019 22:46
@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #3009 into canary will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #3009      +/-   ##
=========================================
- Coverage   11.98%   11.5%   -0.48%     
=========================================
  Files         268     268              
  Lines       10189   10124      -65     
  Branches     1297    1305       +8     
=========================================
- Hits         1221    1165      -56     
+ Misses       8875    8869       -6     
+ Partials       93      90       -3
Impacted Files Coverage Δ
src/util/output/create-output.ts 31.25% <0%> (-12.34%) ⬇️
src/util/prefer-v2-deployment.ts 56.25% <0%> (-5.66%) ⬇️
src/util/get-files.ts 87.77% <0%> (-3.89%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 25% <0%> (-3.58%) ⬇️
src/util/metrics.ts 70.58% <0%> (+2.4%) ⬆️
src/util/dev/builder-cache.ts 80.74% <0%> (+3.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1211ee4...332ca7f. Read the comment docs.

@kodiakhq kodiakhq bot merged commit cded895 into canary Sep 13, 2019
@kodiakhq kodiakhq bot deleted the now-cli/add-tests-for-canary-builders branch September 13, 2019 01:59
styfle pushed a commit that referenced this pull request Sep 17, 2019
* [now-cli] Add test for zero-config and canary builders

* Fix test

* Fix test

* Fix url

* Fix path and export

* Make public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants