Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-cli] Fix 02-angular-node test fail #3058

Merged
merged 2 commits into from Sep 23, 2019

Conversation

thasophearak
Copy link
Contributor

@thasophearak thasophearak changed the title [now-cli] Fix 02-angular-node test failed [now-cli] Fix 02-angular-node test fail Sep 23, 2019
@codecov-io
Copy link

Codecov Report

Merging #3058 into canary will increase coverage by 2.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3058      +/-   ##
==========================================
+ Coverage   11.36%   13.37%   +2.01%     
==========================================
  Files         267      267              
  Lines       10039    10279     +240     
  Branches     1309     1217      -92     
==========================================
+ Hits         1141     1375     +234     
- Misses       8805     8842      +37     
+ Partials       93       62      -31
Impacted Files Coverage Δ
src/util/dev/builder-cache.ts 80.74% <0%> (+3.47%) ⬆️
src/util/get-files.ts 91.66% <0%> (+3.88%) ⬆️
src/util/dev/router.ts 82.69% <0%> (+4.12%) ⬆️
src/util/dev/builder.ts 76.92% <0%> (+4.4%) ⬆️
src/util/dev/yarn-installer.ts 90.74% <0%> (+5.02%) ⬆️
src/util/dev/server.ts 66.43% <0%> (+5.41%) ⬆️
src/util/output/create-output.ts 43.58% <0%> (+12.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e631de4...438ae9f. Read the comment docs.

@thasophearak thasophearak merged commit d23eab6 into canary Sep 23, 2019
@thasophearak thasophearak deleted the now-cli/improve-angular-test branch September 23, 2019 13:30
styfle pushed a commit that referenced this pull request Sep 30, 2019
* Improve `02-angular-node` test

* Add `yarn.lock` with pin version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants