Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-python] Set PIP_USER environment variable #3111

Merged
merged 6 commits into from
Oct 22, 2019
Merged

[now-python] Set PIP_USER environment variable #3111

merged 6 commits into from
Oct 22, 2019

Conversation

numrut
Copy link
Contributor

@numrut numrut commented Oct 1, 2019

Disables --user parameter of the pip utility, which is forcibly set under the hood on Debian systems and causes an error in the pipInstall function:

distutils.errors.DistutilsOptionError: can't combine user with prefix, exec_prefix/home, or install_(plat)base

Fixes #3089

@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #3111 into canary will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3111      +/-   ##
==========================================
+ Coverage   13.33%   13.44%   +0.11%     
==========================================
  Files         268      268              
  Lines       10312    10314       +2     
  Branches     1211     1217       +6     
==========================================
+ Hits         1375     1387      +12     
+ Misses       8877     8865      -12     
- Partials       60       62       +2
Impacted Files Coverage Δ
src/util/prefer-v2-deployment.ts 56.25% <0%> (-5.66%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 25% <0%> (-3.58%) ⬇️
src/util/dev/router.ts 82.35% <0%> (-0.34%) ⬇️
src/util/dev/server.ts 64.8% <0%> (+0.32%) ⬆️
src/util/metrics.ts 70.58% <0%> (+2.4%) ⬆️
src/util/dev/validate.ts 87.87% <0%> (+27.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ffc2d...f98aba9. Read the comment docs.

@styfle
Copy link
Member

styfle commented Oct 4, 2019

Do you have a Dockerfile that can reproduce the original error?

Our CI uses the circleci/node image but that wasn't affected by this bug so I want to check to make sure this really solves the problem for other distros.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 37c06c8 into vercel:canary Oct 22, 2019
@numrut numrut deleted the disable-pip-user branch October 23, 2019 09:16
leo pushed a commit that referenced this pull request Oct 25, 2019
Disables `--user` parameter of the `pip` utility, which is forcibly set under the hood on Debian systems and causes an error in the `pipInstall` function:

`distutils.errors.DistutilsOptionError: can't combine user with prefix, exec_prefix/home, or install_(plat)base`

Fixes #3089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[now dev] fails with @now/python on Debian/Ubuntu
3 participants