Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-client] Add apiUrl support #3168

Merged
merged 15 commits into from
Oct 23, 2019
Merged

[now-client] Add apiUrl support #3168

merged 15 commits into from
Oct 23, 2019

Conversation

rdev
Copy link
Contributor

@rdev rdev commented Oct 17, 2019

This PR adds support for apiUrl option to now-client as well as a test for it

@rdev rdev requested review from styfle and AndyBitz October 17, 2019 17:41
@styfle styfle changed the title Add apiUrl support to now-client [now-client] Add apiUrl support Oct 17, 2019
Co-Authored-By: Steven <steven@ceriously.com>
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the tests pass, thanks!

@kodiakhq kodiakhq bot merged commit 94a2b01 into canary Oct 23, 2019
@kodiakhq kodiakhq bot deleted the fix/api-url-now-client branch October 23, 2019 09:32
leo pushed a commit that referenced this pull request Oct 25, 2019
This PR adds support for `apiUrl` option to `now-client` as well as a test for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants