[now-client] Change npm publish to use files key #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
changed the title
TooTallNate
approved these changes
Oct 21, 2019
Codecov Report
@@ Coverage Diff @@
## canary #3181 +/- ##
==========================================
+ Coverage 13.33% 13.54% +0.21%
==========================================
Files 268 268
Lines 10312 10335 +23
Branches 1211 1212 +1
==========================================
+ Hits 1375 1400 +25
+ Misses 8877 8873 -4
- Partials 60 62 +2
Continue to review full report at Codecov.
|
leo
pushed a commit
that referenced
this pull request
Oct 25, 2019
- remove `.npmignore` - use [`files`](https://docs.npmjs.com/files/package.json#files) key in `package.json` - update metadata in `package.json` - fix test harness to generate a token for each test deployment This PR will prevent publishing [tests](https://cdn.jsdelivr.net/npm/now-client@5.2.0/tests/) to npm and any other unused files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.npmignorefileskey inpackage.jsonpackage.jsonThis PR will prevent publishing tests to npm and any other unused files.