[now-client] [now-cli] Update version of deployment API #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #3188 +/- ##
==========================================
+ Coverage 13.33% 13.54% +0.21%
==========================================
Files 268 268
Lines 10312 10335 +23
Branches 1211 1212 +1
==========================================
+ Hits 1375 1400 +25
+ Misses 8877 8873 -4
- Partials 60 62 +2
Continue to review full report at Codecov.
|
leo
approved these changes
Oct 23, 2019
rdev
approved these changes
Oct 23, 2019
leo
changed the title
thasophearak
deleted the
PRODUCT-28/update-now-client-deployment-api-version
branch
leo
pushed a commit
that referenced
this pull request
Oct 25, 2019
* Update version of deployment API * Add `alias-assigned` event and handling * Replace v9 api with v10 * Don't return on immediate ready * Handle alias-assigned for v1 deployments * Improve event ordering * Detect upload deployment readiness by `alias-assigned` * rebuild * Fix upload readiness event type * Check for aliases before running status checks * Improve event flow and wait for `ready` in v1 deployments * Remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures that new deployments will use the latest version of the deployments API.
More details: https://zeit.atlassian.net/browse/PRODUCT-28