Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-build-utils] Add more complete PackageJson typings #3198

Merged
merged 4 commits into from
Oct 24, 2019

Conversation

TooTallNate
Copy link
Member

Planning on using this in now-cli.

Planning on using this in `now-cli`.
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I think you can modify now-cli in the same PR as now-build-utils since its a monorepo 😉

@TooTallNate TooTallNate merged commit c7caa7b into canary Oct 24, 2019
@TooTallNate TooTallNate deleted the update/build-utils-package-json-types branch October 24, 2019 23:02
leo pushed a commit that referenced this pull request Oct 25, 2019
* [now-build-utils] Add more complete `PackageJson` typings

Planning on using this in `now-cli`.

* Make "name" optional

* Use a namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants