Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test stability #3208

Merged
merged 15 commits into from
Oct 26, 2019
Merged

Improve test stability #3208

merged 15 commits into from
Oct 26, 2019

Conversation

leo
Copy link
Contributor

@leo leo commented Oct 26, 2019

This pull request aims to make our test suite more stable.

@leo leo requested a review from TooTallNate as a code owner October 26, 2019 12:02
@leo leo added the automerge label Oct 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #3208 into master will decrease coverage by 1.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3208      +/-   ##
==========================================
- Coverage   13.17%   11.89%   -1.28%     
==========================================
  Files         268      268              
  Lines       10299    10171     -128     
  Branches     1218     1295      +77     
==========================================
- Hits         1357     1210     -147     
+ Misses       8884     8872      -12     
- Partials       58       89      +31
Impacted Files Coverage Δ
src/util/dev/server.ts 57.6% <0%> (-5.85%) ⬇️
src/util/dev/builder.ts 72.72% <0%> (-5.6%) ⬇️
src/util/dev/builder-cache.ts 74.24% <0%> (-5.27%) ⬇️
src/util/dev/yarn-installer.ts 85.71% <0%> (-5.03%) ⬇️
src/util/dev/router.ts 78.57% <0%> (-4.13%) ⬇️
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/get-config.ts 0% <0%> (ø) ⬆️
src/util/deploy/process-deployment.ts 0% <0%> (ø) ⬆️
src/util/errors-ts.ts 47.51% <0%> (+0.02%) ⬆️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c336353...ee3db9d. Read the comment docs.

@leo leo requested review from AndyBitz and removed request for TooTallNate October 26, 2019 15:19
@kodiakhq kodiakhq bot merged commit d567b5f into master Oct 26, 2019
@kodiakhq kodiakhq bot deleted the fix-tests branch October 26, 2019 15:53
leo added a commit that referenced this pull request Oct 26, 2019
This pull request aims to make our test suite more stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants