Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-routing-utils] Fix validation for routes/cleanUrls #3211

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 28, 2019

This fixes an issue when routes is normalized to null which should be treated the same as undefined.

@codecov-io
Copy link

Codecov Report

Merging #3211 into canary will increase coverage by 2.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3211      +/-   ##
==========================================
+ Coverage   11.47%   13.55%   +2.08%     
==========================================
  Files         268      268              
  Lines       10096    10354     +258     
  Branches     1313     1217      -96     
==========================================
+ Hits         1159     1404     +245     
- Misses       8847     8888      +41     
+ Partials       90       62      -28
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/dev/router.ts 82.35% <0%> (+3.28%) ⬆️
src/util/dev/builder-cache.ts 80.74% <0%> (+3.47%) ⬆️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
src/util/get-files.ts 91.66% <0%> (+3.88%) ⬆️
src/util/dev/yarn-installer.ts 90.74% <0%> (+5.02%) ⬆️
src/util/dev/server.ts 64.8% <0%> (+5.56%) ⬆️
src/util/dev/builder.ts 78.32% <0%> (+5.59%) ⬆️
src/util/prefer-v2-deployment.ts 61.9% <0%> (+5.65%) ⬆️
src/util/output/create-output.ts 66.66% <0%> (+7.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af513c2...df7aa87. Read the comment docs.

@styfle styfle merged commit 089b29c into canary Oct 28, 2019
@styfle styfle deleted the PRODUCT-341/routing-null branch October 28, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants