[now-build-utils] Validate functions and allow them as config #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Oct 29, 2019
styfle
reviewed
Oct 29, 2019
styfle
reviewed
Oct 29, 2019
styfle
reviewed
Oct 29, 2019
Co-Authored-By: Steven <steven@ceriously.com>
…ithub.com/zeit/now into now-build-utils/update-functions-property
Codecov Report
@@ Coverage Diff @@
## canary #3218 +/- ##
=======================================
Coverage 13.53% 13.53%
=======================================
Files 268 268
Lines 10341 10341
Branches 1217 1217
=======================================
Hits 1400 1400
Misses 8879 8879
Partials 62 62Continue to review full report at Codecov.
|
leo
pushed a commit
that referenced
this pull request
Nov 11, 2019
* [now-build-utils] Validate functions and allow them as config * Apply suggestions from code review Co-Authored-By: Steven <steven@ceriously.com> * Change memory check * Adjust test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to validate the
functionsproperty to make sure users are aware of errors during development.We also don't want to apply the function data to the builds, since a build could output multiple lambdas, which will use this instead.