Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-routing-utils] Fix redirects when cleanUrls and trailingSlash #3223

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 30, 2019

This fixes the scenario when both { cleanUrls: true, and trailingSlash: true } so that only one redirect occurs when visiting /file.html.

Previously, this would have redirected twice from /file.html => /file => /file/.

Now it will redirect once from /file.html => /file/.

@kodiakhq kodiakhq bot merged commit 6d04016 into canary Oct 30, 2019
@kodiakhq kodiakhq bot deleted the PRODUCT-341/mixed-clean-trailing branch October 30, 2019 18:27
leo pushed a commit that referenced this pull request Nov 11, 2019
…3223)

This fixes the scenario when both `{ cleanUrls: true, and trailingSlash: true }` so that only one redirect occurs when visiting `/file.html`.

Previously, this would have redirected twice from `/file.html` => `/file` => `/file/`.

Now it will redirect once from `/file.html` => `/file/`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants