Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[now-client] Add .nowignore test #3264

Merged
merged 1 commit into from
Nov 7, 2019
Merged

[now-client] Add .nowignore test #3264

merged 1 commit into from
Nov 7, 2019

Conversation

rdev
Copy link
Contributor

@rdev rdev commented Nov 7, 2019

This adds a test for #3186

@rdev rdev requested a review from styfle November 7, 2019 17:06
@rdev rdev requested a review from leo as a code owner November 7, 2019 17:06
styfle
styfle approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle changed the title Add .nowignore test to now-client [now-client] Add .nowignore test Nov 7, 2019
@kodiakhq kodiakhq bot merged commit 7ecdfbb into canary Nov 7, 2019
@kodiakhq kodiakhq bot deleted the add/now-client-ignore-test branch November 7, 2019 17:23
leo pushed a commit that referenced this pull request Nov 11, 2019
@rdev @leo
[now-client] Add .nowignore test (#3264)
cb40985 
This adds a test for #3186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@leo leo Awaiting requested review from leo

Assignees
No one assigned
Labels
area: client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdev @styfle