[all] Updated builders to version: 3
#3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c495ba.
styfle
reviewed
Nov 8, 2019
styfle
reviewed
Nov 8, 2019
Co-Authored-By: Steven <steven@ceriously.com>
…builder-version-3
styfle
reviewed
Nov 8, 2019
styfle
reviewed
Nov 8, 2019
Co-Authored-By: Steven <steven@ceriously.com>
leo
approved these changes
Nov 8, 2019
leo
requested review from
coetry,
lucleray,
thasophearak and
TooTallNate
as code owners
styfle
reviewed
Nov 8, 2019
| } else if (builder.version === 3) { | ||
| const { output, ...rest } = buildResultOrOutputs; | ||
|
|
||
| if ((output as BuilderOutput).type !== 'Lambda') { |
There was a problem hiding this comment.
I think you can separate the possible output types by doing:
if (Array.isArray(output)) {
throw new Error(`The result of "builder.build" must be a single Lambda, not an array'`);
}
if (output.type !== 'Lambda') {
throw new Error(`The result of "builder.build" must be of type Lambda'`);
}There was a problem hiding this comment.
Unfortunately that doesn't work, I couldn't find a way around the casting
There was a problem hiding this comment.
@styfle I've tried to reduce the casting. However, those are sort of assertion checks, so if we wouldn't cast them TypeScript would complain that this is always true, but this is the builder result, which could actually be any, since we don't control what it returns.
styfle
reviewed
Nov 8, 2019
leo
pushed a commit
that referenced
this pull request
Nov 11, 2019
* [now-node] Use builder version 3 * [now-cgi] Use builder version 3 * [now-go] Use builder version 3 * [now-python] Use builder version 3 * [now-ruby] Use builder version 3 * Adjust docs * [now-ruby] Remove unused import * Temp. test in iad1 * Revert "Temp. test in iad1" This reverts commit 4c495ba. * [now-cli] Adjust `now dev` for builder version 3 * [now-build-utils] Do not allow non Community Runtimes * Temp. Force Build in iad1 * Update DEVELOPING_A_RUNTIME.md Co-Authored-By: Steven <steven@ceriously.com> * Update docs * Update test/lib/deployment/now-deploy.js Co-Authored-By: Steven <steven@ceriously.com> * Remove temp. iad1 check * Check memory and maxDuration * Use memory for Lambda * Only cast once * Skip tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now devsupport runtime version 3runtimePRODUCT-27