Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-next] Add loading of custom routes #3279

Merged
merged 16 commits into from
Nov 10, 2019
Merged

[now-next] Add loading of custom routes #3279

merged 16 commits into from
Nov 10, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 10, 2019

This adds loading of redirects and rewrites from the routes-manifest in supported Next.js versions

@ijjk ijjk requested a review from Timer as a code owner November 10, 2019 02:12
@ijjk ijjk changed the title [now-next][WIP] Add loading of custom routes [now-next] Add loading of custom routes Nov 10, 2019
@ijjk ijjk added the @now/next label Nov 10, 2019
@kodiakhq kodiakhq bot merged commit ce241e7 into canary Nov 10, 2019
@kodiakhq kodiakhq bot deleted the next/custom-routes branch November 10, 2019 07:18
@codecov-io
Copy link

Codecov Report

Merging #3279 into canary will increase coverage by 2.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary    #3279     +/-   ##
=========================================
+ Coverage    11.8%   13.91%   +2.1%     
=========================================
  Files         267      267             
  Lines       10035    10297    +262     
  Branches     1330     1241     -89     
=========================================
+ Hits         1185     1433    +248     
- Misses       8757     8798     +41     
+ Partials       93       66     -27
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/dev/builder-cache.ts 85.18% <0%> (+2.57%) ⬆️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
src/util/get-files.ts 91.66% <0%> (+3.88%) ⬆️
src/util/dev/yarn-installer.ts 90.74% <0%> (+5.02%) ⬆️
src/util/prefer-v2-deployment.ts 61.9% <0%> (+5.65%) ⬆️
src/util/dev/server.ts 64.5% <0%> (+5.81%) ⬆️
src/util/dev/builder.ts 71.59% <0%> (+7.25%) ⬆️
src/util/output/create-output.ts 66.66% <0%> (+7.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72cbfb...641e299. Read the comment docs.

leo pushed a commit that referenced this pull request Nov 11, 2019
This adds loading of `redirects` and `rewrites` from the `routes-manifest` in supported Next.js versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants