Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-client] Fix publish output #3315

Merged
merged 7 commits into from
Nov 14, 2019
Merged

[now-client] Fix publish output #3315

merged 7 commits into from
Nov 14, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 14, 2019

Fixes #3310

The root package.json file is copied to dist by tsc because of a relative import. This causes npm files property to be nested and therefore skip publishing most of the files.

import pkg from '../../package.json';

Disabling resolveJsonModule and using require() instead fixed it.

However, this change caused now-cli build to fail so I had to change the way now-client gets imported.

@kodiakhq kodiakhq bot merged commit f6fdde8 into master Nov 14, 2019
@kodiakhq kodiakhq bot deleted the fix-now-client-publish branch November 14, 2019 19:09
TooTallNate pushed a commit that referenced this pull request Dec 4, 2019
This sets `main` in `now-client` to a proper path.

Follow up to #3315.

Fixes #3373.
paulogdm pushed a commit to paulogdm/now that referenced this pull request Dec 5, 2019
This sets `main` in `now-client` to a proper path.

Follow up to vercel#3315.

Fixes vercel#3373.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[now-client] Missing dist files
2 participants