-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[now-cli] Handle uv_cwd
error when cwd is deleted
#3326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
approved these changes
Nov 18, 2019
TooTallNate
requested changes
Nov 18, 2019
styfle
changed the title
[now-cli] Ignore uv_cwd errors
[now-cli] Handle Nov 18, 2019
uv_cwd
error when cwd is deleted
Codecov Report
@@ Coverage Diff @@
## master #3326 +/- ##
=========================================
- Coverage 11.77% 11.68% -0.1%
=========================================
Files 267 267
Lines 10162 10174 +12
Branches 1331 1350 +19
=========================================
- Hits 1197 1189 -8
- Misses 8869 8888 +19
- Partials 96 97 +1
Continue to review full report at Codecov.
|
TooTallNate
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
reportError()
to typescript and adds an ignore list.In particular,
uv_cwd
comes fromprocess.cwd()
so we don't need to track these errors in the case the user deletes their current working directory.This is a follow up to #3194 which handled only one scenario.