Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-cli] Handle uv_cwd error when cwd is deleted #3326

Merged
merged 7 commits into from
Nov 18, 2019
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 18, 2019

Converts reportError() to typescript and adds an ignore list.

In particular, uv_cwd comes from process.cwd() so we don't need to track these errors in the case the user deletes their current working directory.

This is a follow up to #3194 which handled only one scenario.

packages/now-cli/src/index.js Outdated Show resolved Hide resolved
@styfle styfle changed the title [now-cli] Ignore uv_cwd errors [now-cli] Handle uv_cwd error when cwd is deleted Nov 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #3326 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3326     +/-   ##
=========================================
- Coverage   11.77%   11.68%   -0.1%     
=========================================
  Files         267      267             
  Lines       10162    10174     +12     
  Branches     1331     1350     +19     
=========================================
- Hits         1197     1189      -8     
- Misses       8869     8888     +19     
- Partials       96       97      +1
Impacted Files Coverage Δ
src/util/dev/router.ts 77.27% <0%> (-3.5%) ⬇️
src/index.js 0% <0%> (ø) ⬆️
src/util/report-error.js
src/util/report-error.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55acc2...61cfbd1. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 528aefc into master Nov 18, 2019
@kodiakhq kodiakhq bot deleted the fix-sentry branch November 18, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants