Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-routing-utils] Make sure to update segments in destination hash #3517

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 7, 2020

While migrating redirects on /docs I noticed we don't update segments in the hash of the destination. This updates to also handle these segments and adds a test for this behavior

@vercel
Copy link

vercel bot commented Jan 7, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zeit/now/l01fyy6ec
✅ Preview: https://now-git-routing-utils-hash-segments.zeit.now.sh

@ijjk ijjk requested a review from styfle January 7, 2020 20:04
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #3517 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3517      +/-   ##
==========================================
+ Coverage   14.56%   14.59%   +0.03%     
==========================================
  Files         267      267              
  Lines       10769    10798      +29     
  Branches     1484     1485       +1     
==========================================
+ Hits         1568     1576       +8     
- Misses       9032     9053      +21     
  Partials      169      169
Impacted Files Coverage Δ
src/util/dev/router.ts 69.33% <0%> (-3.91%) ⬇️
src/util/dev/yarn-installer.ts 79.68% <0%> (-3.65%) ⬇️
src/util/dev/builder-cache.ts 77.88% <0%> (-1.62%) ⬇️
src/util/get-update-command.ts 9.37% <0%> (-0.63%) ⬇️
src/util/dev/builder.ts 65.29% <0%> (-0.6%) ⬇️
src/util/dev/server.ts 59.55% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890de6a...5299e99. Read the comment docs.

@ijjk ijjk added the automerge label Jan 8, 2020
@kodiakhq kodiakhq bot merged commit 6e06b13 into master Jan 8, 2020
@kodiakhq kodiakhq bot deleted the routing-utils/hash-segments branch January 8, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants