Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix scully test #3572

Merged
merged 1 commit into from Jan 10, 2020
Merged

[examples] Fix scully test #3572

merged 1 commit into from Jan 10, 2020

Conversation

AndyBitz
Copy link
Contributor

Fix scully test.

@AndyBitz AndyBitz requested a review from styfle as a code owner January 10, 2020 21:19
@vercel
Copy link

vercel bot commented Jan 10, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zeit/now/ian7ezf9o
✅ Preview: https://now-git-now-static-build-fix-scully-example.zeit.now.sh

styfle
styfle approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine if the test passes 👍

@AndyBitz AndyBitz merged commit 1e308dc into master Jan 10, 2020
@AndyBitz AndyBitz deleted the now-static-build/fix-scully-example branch January 10, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndyBitz @styfle