Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-routing-utils] Update to not pass used segments in redirect query #3809

Merged
merged 4 commits into from Feb 19, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 19, 2020

This updates to not pass segments already used in a redirect's destination query since these values are most likely unwanted and can still be manually added if desired. This change does not affect rewrites and we still pass through all segments in the query

Co-Authored-By: Steven <steven@ceriously.com>
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! 🏅

@kodiakhq kodiakhq bot merged commit 1bc1e8a into master Feb 19, 2020
@kodiakhq kodiakhq bot deleted the routing-utils/redirect-query branch February 19, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants